[PATCH v5 00/13] virdnsmasq: Lookup DNSMASQ in PATH

Andrea Bolognani abologna at redhat.com
Tue Jan 18 15:05:44 UTC 2022

On Tue, Jan 18, 2022 at 03:37:07PM +0100, Michal Privoznik wrote:
> v5 of:
> https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html
> diff to v4:
> - Switched to virCommandSetDryRun() in commit 10/13, because using a
>   separate script was conflicting with ASAN. Tried to debug, failed
>   miserably.
> - Extended error message from patch 11/13 to include
>   virGetLastErrorMessage() (because if a test fails one simply doesn't
>   access libvirt log in the CI).
> Michal Prívozník (13):
>   virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
>   lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
>   virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal()
>   virdnsmasq: Drop mtime member from struct _dnsmasqCaps
>   virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps
>   virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
>   virdnsmasq: Don't run 'dnsmasq --help'
>   virdnsmasq: Lookup DNSMASQ in PATH
>   virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
>   networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
>   networkxml2conftest: Check if capabilities were created successfully
>   virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
>   virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

Andrea Bolognani / Red Hat / Virtualization

More information about the libvir-list mailing list