[libvirt PATCH] qemu: fix inactive snapshot revert

Ján Tomko jtomko at redhat.com
Thu Jan 20 14:15:34 UTC 2022

On a Thursday in 2022, Peter Krempa wrote:
>On Thu, Jan 20, 2022 at 14:59:22 +0100, Ján Tomko wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=2039136
>Determining what's being fixed is left as an excercise for the reader?

I have written this commit message before pushing:

The commit splitting out the qemuSnapshotRevertInactive function
dropped the 'defined = true' line by accident and instead
returned -1, leaving the user with a cryptic error:
error: An error occurred, but the cause is unknown


>> Fixes: 85e4a13c3f19078fb6af5ffb4a80022c142cbc7e
>> Signed-off-by: Ján Tomko <jtomko at redhat.com>
>> ---
>>  src/qemu/qemu_snapshot.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>Consider explaining a bit what's going on in the commit message.
>Reviewed-by: Peter Krempa <pkrempa at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220120/88dbb364/attachment-0001.sig>

More information about the libvir-list mailing list