[PATCH] Revert "report error when virProcessGetStatInfo() is unable to parse data"

Andrea Bolognani abologna at redhat.com
Thu Jan 20 14:27:36 UTC 2022


On Tue, Jan 18, 2022 at 12:44:51PM +0100, Michal Privoznik wrote:
> +++ b/src/util/virprocess.c
> @@ -1784,10 +1784,7 @@ virProcessGetStatInfo(unsigned long long *cpuTime,
>          virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_STIME], NULL, 10, &systime) < 0 ||
>          virStrToLong_l(proc_stat[VIR_PROCESS_STAT_RSS], NULL, 10, &rss) < 0 ||
>          virStrToLong_i(proc_stat[VIR_PROCESS_STAT_PROCESSOR], NULL, 10, &cpu) < 0) {
> -        virReportError(VIR_ERR_INTERNAL_ERROR,
> -                       _("cannot parse process status data for pid '%d/%d'"),
> -                       (int) pid, (int) tid);
> -        return -1;
> +        VIR_WARN("cannot parse process status data");

Shame to lose the improved error/warning message. Perhaps it could be
reintroduced separately.

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list