[PATCH v2 2/3] kbase: debuglogs: Fix for modular daemons

[Erik Skultety]

On Thu, Jan 20, 2022 at 04:34:02PM +0100, Peter Krempa wrote:
> Modular daemons are now the default in many new installations, thus we
> need to include steps how to determine that modular daemons are used and
> modular-daemon specific locations for the config files and admin URIs.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  docs/kbase/debuglogs.rst | 98 ++++++++++++++++++++++++++++++++--------
>  1 file changed, 79 insertions(+), 19 deletions(-)
> 
> diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst
> index c3d4d3a425..d2632cfff1 100644
> --- a/docs/kbase/debuglogs.rst
> +++ b/docs/kbase/debuglogs.rst
> @@ -92,38 +92,94 @@ important.
>  Libvirt daemons logging configuration
>  =====================================
> 
> +Libvirt daemons can be configured either via a config file or via the
> +administration API. The configuration location depends on multiple factors.
> +
> +Session vs system daemons
> +-------------------------
> +
> +Libvirt daemons run either in the ``system`` mode or on ``session`` (user)

s/on/in the/

> +mode, depending on the configuration of the host and available permission
> +levels.
> +
> +The `connection URI <https://libvirt.org/uri.html>`__ influences which daemon
> +the client will communicate with.
> +
> +System daemon mode
> +~~~~~~~~~~~~~~~~~~
> +  * all connection URIs end in ``/system`` e.g. ``qemu:///system``
> +
> +  * config files are usually placed in ``/etc/libvirt``
> +
> +Session daemon mode
> +~~~~~~~~~~~~~~~~~~~
> +
> +  * connection URIs end in ``/session``
> +
> +  * config files are usually placed in ``$XDG_CONFIG_HOME/libvirt/`` directory
> +
> +Modular vs. monolithic daemons
> +------------------------------
> +
> +While there is only a single 'libvirtd.conf' configuration file in case of the
> +monolithic daemon setup, each of the modular daemons has their own
> +configuration file giving you a lot of possibilities how to configure them
> +individually including logging. Realistically though, logging will have to be
> +configured only for a single or a couple of daemons in case debug logs are
> +requested.
> +
> +
> +Refer to `documentation about daemons <../daemons.html#checking-whether-modular-monolithic-mode-is-in-use>`__
> +to figure out which is in use by your system.
> +
> +Modular daemons
> +~~~~~~~~~~~~~~~
> +
> +The configuration of modular daemons is in file named after the daemon. E.g.

Okay, so you didn't want to go with my lengthy suggestion :), but we still need
to improve ^this sentence a little, how about:

"Each modular daemon has its own dedicated configuration file named after
itself, e.g. ..."


Reviewed-by: Erik Skultety <eskultet at redhat.com>