[PATCH] Revert "report error when virProcessGetStatInfo() is unable to parse data"

Ani Sinha ani at anisinha.ca
Thu Jan 20 17:23:33 UTC 2022

On Thu, Jan 20, 2022 at 21:29 Michal Prívozník <mprivozn at redhat.com> wrote:

> On 1/20/22 16:48, Ani Sinha wrote:
> >
> >
> >
> > AKA kicking the can one more time 🙃
> Well, I should have been more careful and not merge the patch in the
> first place. Changing API behavior is something we should never do.
> Looking at the code closer, it looks like all callers of this function
> would need to ignore the reported error so that their behavior is not
> changed. At this point, does it make sense to report an error in the
> function?

The callers can decide what do with the error raised by the function. We
should not write functions that cannot fail.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220120/29dad179/attachment-0001.htm>

More information about the libvir-list mailing list