[PATCH 10/11] virDomainTimerDefFormat: return void

Michal Privoznik mprivozn at redhat.com
Mon Jan 24 10:07:32 UTC 2022


This function never returns an error, make it void then.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/conf/domain_conf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 55626a6d01..a5fa3acd32 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26100,7 +26100,7 @@ virDomainInputDefFormat(virBuffer *buf,
 }
 
 
-static int
+static void
 virDomainTimerDefFormat(virBuffer *buf,
                         virDomainTimerDef *def)
 {
@@ -26145,8 +26145,6 @@ virDomainTimerDefFormat(virBuffer *buf,
 
     virXMLFormatElement(&timerChld, "catchup", &catchupAttr, NULL);
     virXMLFormatElement(buf, "timer", &timerAttr, &timerChld);
-
-    return 0;
 }
 
 static void
@@ -28191,8 +28189,7 @@ virDomainDefFormatInternalSetRootName(virDomainDef *def,
         virBufferAddLit(buf, ">\n");
         virBufferAdjustIndent(buf, 2);
         for (n = 0; n < def->clock.ntimers; n++) {
-            if (virDomainTimerDefFormat(buf, def->clock.timers[n]) < 0)
-                return -1;
+            virDomainTimerDefFormat(buf, def->clock.timers[n]);
         }
         virBufferAdjustIndent(buf, -2);
         virBufferAddLit(buf, "</clock>\n");
-- 
2.34.1




More information about the libvir-list mailing list