[PATCH 03/33] qemu_capabilities.c: use 'MachineIsPowerPC' in DeviceDiskCaps

Daniel Henrique Barboza danielhb413 at gmail.com
Mon Jan 24 11:30:59 UTC 2022



On 1/21/22 10:44, Peter Krempa wrote:
> On Thu, Jan 20, 2022 at 10:52:06 -0300, Daniel Henrique Barboza wrote:
>> Both pSeries and PowerNV machines don't have floppy device support.
>>
>> qemuDomainMachineIsPSeries() can be turned into static since it's
>> now unused outside of qemu_domain.c.
> 
> Preferably don't bundle two not related changes into one commit.
> 
>>
>> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>> ---
>>   src/qemu/qemu_capabilities.c | 4 ++--
>>   src/qemu/qemu_domain.c       | 2 +-
>>   src/qemu/qemu_domain.h       | 2 --
>>   3 files changed, 3 insertions(+), 5 deletions(-)
> 
> With the commits split:
> 
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>

Thanks. I split the commit as suggested.


Daniel

> 




More information about the libvir-list mailing list