[PATCH] qemuDomainSetupDisk: Initialize 'targetPaths'

Andrea Bolognani abologna at redhat.com
Tue Jan 25 17:20:11 UTC 2022


On Tue, Jan 25, 2022 at 05:59:28PM +0100, Peter Krempa wrote:
> Compiler isn't able to see that 'virDevMapperGetTargets' in cases e.g.
> when the devmapper isn't available may not initialize the value in the
> pointer passed as the second argument.
>
> The usage 'qemuDomainSetupDisk' lead to an accidental infinite loop as
> previous calls apparently doctored the stack to a point where
> 'g_slist_concat' would end up in an infinite loop trying to find the end
> of the list.
>
> Fixes: 6c49c2ee9fc

Full commit hash here maybe?

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list