[libvirt PATCH 1/3] mingw: Don't ship virt-admin

Daniel P. Berrangé berrange at redhat.com
Wed Jan 26 09:49:12 UTC 2022


On Tue, Jan 25, 2022 at 07:03:37PM +0100, Andrea Bolognani wrote:
> virt-admin can only be used to configure the local daemon, and
> we don't build the daemon for Windows.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  mingw-libvirt.spec.in | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
> index dbcb6d4b8f..01beb6ff18 100644
> --- a/mingw-libvirt.spec.in
> +++ b/mingw-libvirt.spec.in
> @@ -200,7 +200,6 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
>  
>  %{mingw32_bindir}/libvirt-0.dll
>  %{mingw32_bindir}/virsh.exe
> -%{mingw32_bindir}/virt-admin.exe
>  %{mingw32_bindir}/virt-xml-validate
>  %{mingw32_bindir}/virt-pki-validate
>  %{mingw32_bindir}/libvirt-lxc-0.dll
> @@ -253,7 +252,6 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
>  %{mingw32_includedir}/libvirt/libvirt-admin.h
>  
>  %{mingw32_mandir}/man1/virsh.1*
> -%{mingw32_mandir}/man1/virt-admin.1*
>  %{mingw32_mandir}/man1/virt-xml-validate.1*
>  %{mingw32_mandir}/man1/virt-pki-validate.1*
>  %{mingw32_mandir}/man7/virkey*.7*
> @@ -266,7 +264,6 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
>  
>  %{mingw64_bindir}/libvirt-0.dll
>  %{mingw64_bindir}/virsh.exe
> -%{mingw64_bindir}/virt-admin.exe
>  %{mingw64_bindir}/virt-xml-validate
>  %{mingw64_bindir}/virt-pki-validate
>  %{mingw64_bindir}/libvirt-lxc-0.dll
> @@ -319,7 +316,6 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
>  %{mingw64_includedir}/libvirt/libvirt-admin.h
>  
>  %{mingw64_mandir}/man1/virsh.1*
> -%{mingw64_mandir}/man1/virt-admin.1*
>  %{mingw64_mandir}/man1/virt-xml-validate.1*
>  %{mingw64_mandir}/man1/virt-pki-validate.1*
>  %{mingw64_mandir}/man7/virkey*.7*

Simply removing entries from %files will result in RPM exiting with an
error message that files were installed in the virtual root but not
included in %files.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list