[libvirt PATCH 3/5] meson: Don't check whether qemu_user and qemu_group exist

Andrea Bolognani abologna at redhat.com
Wed Jan 26 15:13:14 UTC 2022


QEMU might not be installed on the build system, in which case
the user and group will not be present. We should avoid falling
back to root:root in that case, and assume the user and group
are going to be present in the target system instead.

Suggested-by: Olaf Hering <olaf at aepfle.de>
Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 meson.build | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/meson.build b/meson.build
index 388e2cfa5e..f08a25f53c 100644
--- a/meson.build
+++ b/meson.build
@@ -1678,14 +1678,6 @@ if not get_option('driver_qemu').disabled()
         default_qemu_user = 'root'
         default_qemu_group = 'root'
       endif
-      # If the expected user and group don't exist, or we haven't hit any
-      # of the cases above bacuse we're running on an unknown OS, the only
-      # sensible fallback is root:root
-      if (run_command('getent', 'passwd', default_qemu_user, check: false).returncode() != 0 and
-          run_command('getent', 'group', default_qemu_group, check: false).returncode() != 0)
-        default_qemu_user = 'root'
-        default_qemu_group = 'root'
-      endif
     endif
     qemu_user = get_option('qemu_user')
     if qemu_user == ''
-- 
2.34.1




More information about the libvir-list mailing list