[PATCH v1] meson: recognize sles when guessing default_qemu_user

Andrea Bolognani abologna at redhat.com
Wed Jan 26 15:14:34 UTC 2022


On Wed, Jan 26, 2022 at 02:31:01PM +0100, Olaf Hering wrote:
> Tue, 25 Jan 2022 10:11:01 -0800 Andrea Bolognani <abologna at redhat.com>:
> > Do you mean that if the user has passed
> >   -Dqemu_user=... -Dqemu_group=...
> > to meson we could skip the detection logic? That'd be nice, but I'm
> > afraid it might make the code less readable for very little gain.
>
> The whole thing will be just a whitespace change because it goes into its own block:
> This looks like an opportunity to get rid of default_qemu_user/group.
>
> The getent part is bogus because it forces the user/group to be present on the system
> which is building libvirt. This build system is usually not the system which runs libvirt.
> Please fix bug this as well.

Patches here:

  https://listman.redhat.com/archives/libvir-list/2022-January/msg01189.html

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list