[libvirt PATCH 0/4] move virParseVersionString to virstring.c

[Laine Stump]

On 1/28/22 3:58 PM, Ján Tomko wrote:
> And clean up some includes while doing it.
> 
> Ján Tomko (4):
>    maint: add required includes
>    util: virParseVersionString: move to virstring.c
>    virParseVersionString: rename to virStringParseVersion
>    maint: remove unnecessary virutil.h includes

Reviewed-by: Laine Stump <laine at redhat.com>

but beware the slippery slope (e.g. - if you're going to move this one, 
then what about virIndexToDiskName and virDiskNameToIndex - they just 
operate on a string too...). Do we really want such specific functions 
in a file made for generally useful string functions? (Maybe we do, I 
don't have a strong opinion one way or the other, just thought I'd bring 
it up)


> 
>   src/bhyve/bhyve_driver.c                  |  2 +-
>   src/ch/ch_conf.c                          |  2 +-
>   src/esx/esx_vi.c                          |  9 ++---
>   src/libvirt_private.syms                  |  2 +-
>   src/lxc/lxc_driver.c                      |  2 +-
>   src/nwfilter/nwfilter_ebiptables_driver.c |  6 +--
>   src/openvz/openvz_conf.c                  |  3 +-
>   src/util/virdnsmasq.c                     |  3 +-
>   src/util/virfirewalld.c                   |  4 +-
>   src/util/virstring.c                      | 48 +++++++++++++++++++++++
>   src/util/virstring.h                      |  4 ++
>   src/util/virutil.c                        | 46 ----------------------
>   src/util/virutil.h                        |  3 --
>   src/vbox/vbox_common.c                    |  2 +-
>   src/vmware/vmware_conf.c                  |  3 +-
>   src/vz/vz_utils.c                         |  2 +-
>   tests/testutilsqemu.c                     |  3 +-
>   tests/utiltest.c                          |  2 +-
>   tools/virt-host-validate-common.c         |  2 +-
>   19 files changed, 73 insertions(+), 75 deletions(-)
>