[PATCH v4 00/13] virdnsmasq: Lookup DNSMASQ in PATH

Michal Privoznik mprivozn at redhat.com
Mon Jan 17 15:19:14 UTC 2022


v4 of:

https://listman.redhat.com/archives/libvir-list/2022-January/msg00498.html

diff to v3:
- Removed even more code
- Switched from virCommandDryRun to a python script, per Andrea's
  request
- Reordered patches so that the mock doesn't need to redirect stat()
- Renamed mock
- Removed exec() of 'dnsmasq --help'

Michal Prívozník (13):
  virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
  lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
  virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal()
  virdnsmasq: Drop mtime member from struct _dnsmasqCaps
  virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps
  virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
  virdnsmasq: Don't run 'dnsmasq --help'
  virdnsmasq: Lookup DNSMASQ in PATH
  virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
  networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
  networkxml2conftest: Check if capabilities were created successfully
  virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
  virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()

 meson.build                 |  1 -
 src/libvirt_private.syms    |  1 -
 src/util/virdnsmasq.c       | 84 ++++++-------------------------------
 src/util/virdnsmasq.h       |  1 -
 tests/dnsmasqmock.py        | 13 ++++++
 tests/meson.build           |  1 +
 tests/networkxml2conftest.c | 13 +++---
 tests/virdnsmasqmock.c      | 19 +++++++++
 8 files changed, 54 insertions(+), 79 deletions(-)
 create mode 100755 tests/dnsmasqmock.py
 create mode 100644 tests/virdnsmasqmock.c

-- 
2.34.1




More information about the libvir-list mailing list