[libvirt PATCH 6/9] libvirt: introduce virConnectGetHypervisorCPUModelDefinition public API

[Daniel P. Berrangé]

On Mon, Jul 18, 2022 at 11:26:07AM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 28, 2022 at 06:09:43PM +0200, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
> > ---
> >  include/libvirt/libvirt-host.h |  7 +++++
> >  src/driver-hypervisor.h        |  9 ++++++
> >  src/libvirt-host.c             | 54 ++++++++++++++++++++++++++++++++++
> >  src/libvirt_public.syms        |  1 +
> >  4 files changed, 71 insertions(+)
> > 
> > diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h
> > index 5aaa001adb..ad11c1172d 100644
> > --- a/include/libvirt/libvirt-host.h
> > +++ b/include/libvirt/libvirt-host.h
> > @@ -968,6 +968,13 @@ int virConnectGetHypervisorCPUModelNames(virConnectPtr conn,
> >                                           char ***aliases,
> >                                           unsigned int flags);
> >  
> > +int virConnectGetHypervisorCPUModelDefinition(virConnectPtr conn,
> > +                                              const char *arch,
> > +                                              const char *machine,
> 
> Now we've got machine + arch, but still haven't got 'virttype' and
> 'emulator' parameters
> 
> > +                                              const char *name,
> > +                                              char **xmlCPU,
> > +                                              unsigned int flags);
> > +

I'm not actually convinced this new API is needed at all. Thue
virConnectBaselineHypervisorCPU API has a flag
VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES to let you expand all
features in a given CPU model name.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|