[PATCH 1/2] glibcompat: Provide implementation for G_GNUC_NO_INLINE

[Pavel Hrdina]

On Mon, Jul 18, 2022 at 04:03:15PM +0200, Michal Privoznik wrote:
> Currently, we require glib-2.56.0 at minimum (because of RHEL-8)
> but we use G_GNUC_NO_INLINE which was introduced in 2.58.0. While
> we provide an implementation for older versions, where the macro
> does not exists, it's a bit more tricky than that. Since we
> define GLIB_VERSION_MAX_ALLOWED we would get a compile time error
> when trying to use something too new, except for G_GNUC_NO_INLINE
> which was intentionally not marked as
> GLIB_AVAILABLE_MACRO_IN_2_58. But this is about to change with
> glib-2.73.2 (which contains commit [1]).
> 
> At the same time, we can't just bump glib and thus we have to
> provide an alternative implementation without the version
> annotation.
> 
> 1: https://gitlab.gnome.org/GNOME/glib/-/commit/a6f8fe071e44b0145619c21f3bfbc90c56ab805e
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/internal.h        | 12 ------------
>  src/util/glibcompat.h |  9 +++++++++
>  2 files changed, 9 insertions(+), 12 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220718/e44899c4/attachment.sig>