[libvirt PATCH] qemu_migration: Delete vDPA check

Jiri Denemark jdenemar at redhat.com
Mon Jul 18 15:15:29 UTC 2022


On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
> On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark <jdenemar at redhat.com> wrote:
> > Which in ideal case would mean only a QMP command (such as
> > hotplugging a non-migratable device) is the only way to add migration
> > blocker. If this is true, than we're safe as libvirt does not allow such
> > commands between qemuMigrationSrcIsAllowed and migration start.
> >
> 
> Ok, that rules out a few bad use cases. I can do a fast lookup to
> check if blockers can be added without the knowledge of libvirt.
> 
> > That said, is there a reason for not implementing the correct solution
> > right away as a separate patch?
> >
> 
> I was not sure if libvirt already had another way to check, for
> example, if the vhost device didn't have VHOST_F_LOG_ALL feature.

I'm not aware of such check, but even if it exists, checking for
migration blockers looks like the right way of doing things anyway.

Jirka


More information about the libvir-list mailing list