[PATCH v2 2/2] domain_conf: rewrite if else functions to switch

Martin Kletzander mkletzan at redhat.com
Thu Jul 21 12:58:11 UTC 2022


On Thu, Jul 21, 2022 at 01:30:45PM +0200, Kristina Hanicova wrote:
>Pattern of using switch instead of a long if else construction is
>used everywhere, so I used it here as well to make the code more
>consistent (and remove that else after return). I also included
>all the values from the enum.
>

The commit messages are usually non-subjective, as in:

"... use it here..." and "Also include ...", but it's not a rule.

>Signed-off-by: Kristina Hanicova <khanicov at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220721/0d63e050/attachment.sig>


More information about the libvir-list mailing list