[PATCH v2 3/8] domain_capabilities: reformat virDomainCapsCPUCustomFormat()

Martin Kletzander mkletzan at redhat.com
Thu Jul 21 14:55:42 UTC 2022


On Thu, Jul 21, 2022 at 12:45:48PM +0200, Kristina Hanicova wrote:
>Signed-off-by: Kristina Hanicova <khanicov at redhat.com>

I was thinking if this would look nicer with virXMLFormatElement, but
then I realised it's just a two lines of code and it does not matter at
all =)

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>


>---
> src/conf/domain_capabilities.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
>index 6e8f957657..653123f293 100644
>--- a/src/conf/domain_capabilities.c
>+++ b/src/conf/domain_capabilities.c
>@@ -376,12 +376,14 @@ virDomainCapsCPUCustomFormat(virBuffer *buf,
>
>     for (i = 0; i < custom->nmodels; i++) {
>         virDomainCapsCPUModel *model = custom->models + i;
>+
>         virBufferAsprintf(buf, "<model usable='%s'",
>                           virDomainCapsCPUUsableTypeToString(model->usable));
>+
>         if (model->deprecated)
>             virBufferAddLit(buf, " deprecated='yes'");
>-        virBufferAsprintf(buf, ">%s</model>\n",
>-                          model->name);
>+
>+        virBufferAsprintf(buf, ">%s</model>\n", model->name);
>     }
>
>     virBufferAdjustIndent(buf, -2);
>-- 
>2.35.3
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220721/e9108633/attachment.sig>


More information about the libvir-list mailing list