[PATCH 0/4] jobs: make & use generalized virDomainObjInitJob()

Martin Kletzander mkletzan at redhat.com
Thu Jul 21 15:30:59 UTC 2022


On Thu, Jul 21, 2022 at 01:54:45PM +0200, Kristina Hanicova wrote:
>This series uses qemuDomainObjInitJob() as virDomainObjInitJob() in all

I would prefer to rather use a name "virDomainJobObjInit" since it
initialises the job obj.  It is not a domain object that initialises a
job.

With that changed (and obvious relevant fixed applied)

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>drivers that use virDomainObjJob structure.
>
>Kristina Hanicova (4):
>  qemu & hypervisor: move qemuDomainObjInitJob() into hypervisor
>  libxl: use virDomainObjInitJob()
>  LXC: use virDomainObjInitJob()
>  CH: use virDomainObjInitJob()
>
> src/ch/ch_domain.c          | 13 +------------
> src/hypervisor/domain_job.c | 25 +++++++++++++++++++++++++
> src/hypervisor/domain_job.h |  4 ++++
> src/libvirt_private.syms    |  1 +
> src/libxl/libxl_domain.c    | 17 +++--------------
> src/lxc/lxc_domain.c        | 13 +------------
> src/qemu/qemu_domain.c      |  2 +-
> src/qemu/qemu_domainjob.c   | 26 --------------------------
> src/qemu/qemu_domainjob.h   |  4 ----
> 9 files changed, 36 insertions(+), 69 deletions(-)
>
>-- 
>2.35.3
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220721/f4f6a323/attachment.sig>


More information about the libvir-list mailing list