[PATCH 29/80] qemu: validate: Remove impossible validation checks

Peter Krempa pkrempa at redhat.com
Tue Jul 26 14:37:07 UTC 2022


All supported qemu versions now work with blockdev.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_validate.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index b949e1aa42..4ce920152f 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -609,13 +609,6 @@ qemuValidateDomainDefNvram(const virDomainDef *def,
     if (!src)
         return 0;

-    if (def->os.loader->newStyleNVRAM &&
-        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("modern nvram specification is not supported by this qemu"));
-        return -1;
-    }
-
     switch (src->type) {
     case VIR_STORAGE_TYPE_FILE:
     case VIR_STORAGE_TYPE_BLOCK:
@@ -3182,13 +3175,6 @@ qemuValidateDomainDeviceDefDiskTransient(const virDomainDiskDef *disk,
         return -1;
     }

-    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("transient disk not supported by this QEMU binary (%s)"),
-                       disk->dst);
-        return -1;
-    }
-
     if (disk->transientShareBacking == VIR_TRISTATE_BOOL_YES) {
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SET_ACTION) &&
             !qemuProcessRebootAllowed(def)) {
-- 
2.36.1



More information about the libvir-list mailing list