[libvirt PATCH v2 62/81] qemu: Rename qemuMigrationSrcCleanup
Jiri Denemark
jdenemar at redhat.com
Wed Jun 1 12:50:02 UTC 2022
The function is now called qemuMigrationAnyConnectionClosed to make it
clear it is supposed to handle broken connection during migration. It
will soon be used on both sides of migration so the "Src" part was changed
to "Any" to avoid renaming the function twice in a row.
The original *Cleanup name could easily be confused with cleanup
callbacks called when a domain is destroyed.
Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
---
Notes:
Version 2:
- no change
src/qemu/qemu_migration.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e888384570..eee73d47ca 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2309,8 +2309,8 @@ qemuMigrationDstRun(virQEMUDriver *driver,
* qemuDomainMigratePerform3 and qemuDomainMigrateConfirm3.
*/
static void
-qemuMigrationSrcCleanup(virDomainObj *vm,
- virConnectPtr conn)
+qemuMigrationAnyConnectionClosed(virDomainObj *vm,
+ virConnectPtr conn)
{
qemuDomainObjPrivate *priv = vm->privateData;
virQEMUDriver *driver = priv->driver;
@@ -2800,13 +2800,13 @@ qemuMigrationSrcBeginResumePhase(virConnectPtr conn,
return NULL;
virCloseCallbacksUnset(driver->closeCallbacks, vm,
- qemuMigrationSrcCleanup);
+ qemuMigrationAnyConnectionClosed);
qemuDomainCleanupRemove(vm, qemuProcessCleanupMigrationJob);
xml = qemuMigrationSrcBeginResume(driver, vm, xmlin, cookieout, cookieoutlen, flags);
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
- qemuMigrationSrcCleanup) < 0)
+ qemuMigrationAnyConnectionClosed) < 0)
g_clear_pointer(&xml, g_free);
if (!xml)
@@ -2886,7 +2886,7 @@ qemuMigrationSrcBegin(virConnectPtr conn,
* place.
*/
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
- qemuMigrationSrcCleanup) < 0)
+ qemuMigrationAnyConnectionClosed) < 0)
goto endjob;
}
@@ -3962,7 +3962,7 @@ qemuMigrationSrcConfirm(virQEMUDriver *driver,
goto cleanup;
virCloseCallbacksUnset(driver->closeCallbacks, vm,
- qemuMigrationSrcCleanup);
+ qemuMigrationAnyConnectionClosed);
qemuDomainCleanupRemove(vm, qemuProcessCleanupMigrationJob);
ret = qemuMigrationSrcConfirmPhase(driver, vm,
@@ -5933,7 +5933,7 @@ qemuMigrationSrcPerformResume(virQEMUDriver *driver,
return -1;
virCloseCallbacksUnset(driver->closeCallbacks, vm,
- qemuMigrationSrcCleanup);
+ qemuMigrationAnyConnectionClosed);
qemuDomainCleanupRemove(vm, qemuProcessCleanupMigrationJob);
ret = qemuMigrationSrcPerformNative(driver, vm, NULL, uri,
@@ -5942,7 +5942,7 @@ qemuMigrationSrcPerformResume(virQEMUDriver *driver,
0, NULL, NULL, 0, NULL, NULL, NULL);
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
- qemuMigrationSrcCleanup) < 0)
+ qemuMigrationAnyConnectionClosed) < 0)
ret = -1;
if (ret < 0)
@@ -5998,7 +5998,7 @@ qemuMigrationSrcPerformPhase(virQEMUDriver *driver,
goto cleanup;
virCloseCallbacksUnset(driver->closeCallbacks, vm,
- qemuMigrationSrcCleanup);
+ qemuMigrationAnyConnectionClosed);
if (qemuMigrationSrcPerformNative(driver, vm, persist_xml, uri, cookiein, cookieinlen,
cookieout, cookieoutlen,
@@ -6007,7 +6007,7 @@ qemuMigrationSrcPerformPhase(virQEMUDriver *driver,
goto cleanup;
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
- qemuMigrationSrcCleanup) < 0)
+ qemuMigrationAnyConnectionClosed) < 0)
goto cleanup;
ignore_value(qemuMigrationJobSetPhase(vm, QEMU_MIGRATION_PHASE_PERFORM3_DONE));
--
2.35.1
More information about the libvir-list
mailing list