[PATCH 11/16] include: Introduce typed params for virDomainSetIOThreadParams wrt pool size

[Peter Krempa]

On Thu, Jun 02, 2022 at 09:18:01 +0200, Michal Privoznik wrote:
> Our public API offers virDomainSetIOThreadParams() function which
> allows users to set various aspects of IOThreads. Introduce two
> new typed parameters: VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and
> VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX which will allow users to
> modify the thread-pool-min and thread-pool-max attributes of an
> iothread.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  include/libvirt/libvirt-domain.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index 24846046aa..e1daa7a91d 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -2493,6 +2493,24 @@ int                  virDomainDelIOThread(virDomainPtr domain,
>   */
>  # define VIR_DOMAIN_IOTHREAD_POLL_SHRINK "poll_shrink"
>  
> +/**
> + * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN:

So here you call the enum THREAD_POOL_MIN ... as noted we should do the
same in the XML.

> + *
> + * Set the lower bound.

This could use some more description.

> + *
> + * Since: 8.4.0

8.5.0

> + */
> +# define VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN "thread_pool_min"
> +
> +/**
> + * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX:
> + *
> + * Set the upper bound.
> + *
> + * Since: 8.4.0

-||-

> + */
> +# define VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX "thread_pool_max"
> +
>  int                  virDomainSetIOThreadParams(virDomainPtr domain,
>                                                  unsigned int iothread_id,
>                                                  virTypedParameterPtr params,

Reviewed-by: Peter Krempa <pkrempa at redhat.com>