[libvirt PATCH v2 79/81] Introduce VIR_JOB_MIGRATION_SAFE job type

Peter Krempa pkrempa at redhat.com
Mon Jun 6 13:31:57 UTC 2022


On Wed, Jun 01, 2022 at 14:50:19 +0200, Jiri Denemark wrote:
> This is a special job for operations that need to modify domain state
> during an active migration. The modification must not affect any state
> that could conflict with the migration code. This is useful mainly for
> event handlers that need to be processed during migration and which
> could otherwise time out on acquiring a normal MODIFY job.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> 
> Notes:
>     Version 2:
>     - new patch
> 
>  src/hypervisor/domain_job.c | 1 +
>  src/hypervisor/domain_job.h | 4 ++++
>  src/qemu/qemu_migration.c   | 1 +
>  src/qemu/qemu_process.c     | 7 +++++++
>  4 files changed, 13 insertions(+)

[...]

> diff --git a/src/hypervisor/domain_job.h b/src/hypervisor/domain_job.h
> index fce35ffbf5..24bb93c59f 100644
> --- a/src/hypervisor/domain_job.h
> +++ b/src/hypervisor/domain_job.h
> @@ -31,6 +31,10 @@ typedef enum {
>      VIR_JOB_MODIFY,        /* May change state */
>      VIR_JOB_ABORT,         /* Abort current async job */
>      VIR_JOB_MIGRATION_OP,  /* Operation influencing outgoing migration */
> +    VIR_JOB_MIGRATION_SAFE, /* Internal only job for event handlers which need
> +                               to be processed even during migration. The code
> +                               may only change state in a way that does not
> +                               affect migration. */

'migration safety' is a property of an otherwise 'modify' job, so please
include the word 'MODIFY' in the flag name.

With the rename:

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list