[PATCH v2 12/15] virsh: Wire up new virDomainSetIOThreadParams parameters

Peter Krempa pkrempa at redhat.com
Tue Jun 7 15:10:44 UTC 2022


On Tue, Jun 07, 2022 at 14:52:56 +0200, Michal Privoznik wrote:
> Since virsh implements a wrapper over virDomainSetIOThreadParams()
> (command iothreadset) let's wire up new typed parameters there too.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  docs/manpages/virsh.rst |  7 ++++++-
>  tools/virsh-domain.c    | 24 +++++++++++++++++++++++-
>  2 files changed, 29 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> index 965b89c99d..8c066c9176 100644
> --- a/docs/manpages/virsh.rst
> +++ b/docs/manpages/virsh.rst
> @@ -2993,7 +2993,8 @@ iothreadset
>  ::
>  
>     iothreadset domain iothread_id [[--poll-max-ns ns] [--poll-grow factor]
> -      [--poll-shrink divisor]]
> +      [--poll-shrink divisor] [--thread-pool-min value]
> +      [--thread-pool-max value]]
>        [[--config] [--live] | [--current]]
>  
>  Modifies an existing iothread of the domain using the specified
> @@ -3010,6 +3011,10 @@ for a running guest. Saving, destroying, stopping, etc. the guest will
>  result in the polling values returning to hypervisor defaults at the
>  next start, restore, etc.
>  
> +The *--thread-pool-min* and *--thread-pool-max* options then set lower and
> +upper bound, respectively of number of threads in worker pool of given
> +iothread.

We probably should mention that in certain cases if you pick too high
'min' you'll need to set 'max' first.

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list