[libvirt PATCH 2/2] ci: integration: Set 'safe.directory' when installing QEMU from git

Andrea Bolognani abologna at redhat.com
Thu Jun 9 10:01:34 UTC 2022


On Wed, Jun 08, 2022 at 08:03:07AM +0200, Erik Skultety wrote:
> FWIW we could alternatively update the submodules manually, but we'd have list
> them explicitly, IOW:
>     $ git clone qemu ...
>     $ cd qemu.git
>     $ scripts/git-submodule.sh ui/keycodemapdb dtc slirp

We could avoid hardcoding the names of the submodules by using
something along the lines of

  $ ./scripts/git-submodule.sh update $(git submodule | awk '{print
$2}' | grep -Ev '^(meson|roms/.*|tests/.*)$')

A bit of a mouthful, but should be solid enough.

>     $ mkdir build && cd build
>     $ ../configure ... --with-git-submodules=ignore

Using

  --with-git-submodules=validate

would work too, since we'd have updated the submodules beforehand.


I think I would prefer this approach to changing the git
configuration for the root user.

-- 
Andrea Bolognani / Red Hat / Virtualization



More information about the libvir-list mailing list