[PATCH] storage: pool: Allow more intricate nfs protocol versions

Peter Krempa pkrempa at redhat.com
Thu Jun 23 15:21:12 UTC 2022


On Thu, Jun 23, 2022 at 17:18:18 +0200, Peter Krempa wrote:
> Treat the 'protocolVer' field as a string so that e.g. '4.1' can be
> used.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/conf/schemas/storagepool.rng                   |  4 +---
>  src/conf/storage_conf.c                            | 14 +++-----------
>  src/conf/storage_conf.h                            |  2 +-
>  src/storage/storage_util.c                         |  4 ++--
>  .../pool-netfs-protocol-ver-linux.argv             |  2 +-
>  .../pool-netfs-protocol-ver.xml                    |  2 +-
>  .../pool-netfs-protocol-ver.xml                    |  2 +-
>  7 files changed, 10 insertions(+), 20 deletions(-)

Forgot to commit this:

diff --git a/docs/formatstorage.rst b/docs/formatstorage.rst
index ef15c0ac5c..83d7d141ac 100644
--- a/docs/formatstorage.rst
+++ b/docs/formatstorage.rst
@@ -350,7 +350,7 @@ following child elements:
 ``protocol``
    For a ``netfs`` Storage Pool provide a mechanism to define which NFS protocol
    version number will be used to contact the server's NFS service. The
-   attribute ``ver`` accepts an unsigned integer as the version number to use.
+   attribute ``ver`` accepts the version number to use.
    :since:`Since 5.1.0`
 ``vendor``
    Provides optional information about the vendor of the storage device. This



More information about the libvir-list mailing list