[libvirt PATCH] qemu_migration: Avoid mem.hard_limit > 0 check

Michal Prívozník mprivozn at redhat.com
Mon Jun 27 07:02:25 UTC 2022


On 6/24/22 16:33, Jiri Denemark wrote:
> My original commit v8.4.0-288-gf01fc4d119 accidentally forgot to fix
> both instances of the same problem. While it fixed the destination side
> of migration, the source one remained broken.
> 
> However, that commit was also wrong in saying the issue could have
> caused unlimited memory locking to be allowed for QEMU when RDMA
> migration was used. It could not, because the code would refuse to even
> think about starting RDMA migration if hard_limit was not set. But
> avoiding the "mem.hard_limit > 0" check is useful anyway.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal



More information about the libvir-list mailing list