[PATCH v2] conf: virDomainMemoryDefValidate: Improve error message

Michal Prívozník mprivozn at redhat.com
Tue Jun 28 10:35:23 UTC 2022


On 6/28/22 05:53, Liu Yiding wrote:
> An explicit limit would be more user friendly. Add the limit to error message.
> 
> Before this commit:
> ```
> error: requested size must be smaller than or equal to @size
> ```
> 
> Now:
> ```
> error: requested size must be smaller than or equal to @size (8388608KiB)
> ```
> 
> Signed-off-by: Liu Yiding <liuyd.fnst at fujitsu.com>
> ---
>  src/conf/domain_validate.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Yup, this looks perfect. Thanks!

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

and pushed. Congratulations on your first libvirt contribution!

Michal



More information about the libvir-list mailing list