[PATCH] libxl: remove redundant variable from libxlDomainJobObj

Michal Prívozník mprivozn at redhat.com
Tue Mar 1 10:10:14 UTC 2022


On 2/28/22 11:49, Kristina Hanicova wrote:
> It makes no sense to have 'started' variable in the
> libxlDomainJobObj as the same one is already in virDomainJobData,
> but never used.
> 
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
>  src/libxl/libxl_domain.c | 10 +++++-----
>  src/libxl/libxl_domain.h |  1 -
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

and pushed.

Another supporting argument is that even libxlDomainObjResetJob() does
not reset the job->started. After this patch, maybe it should reset
job->current?

Michal




More information about the libvir-list mailing list