[PATCH] libxl: Turn on user aliases

[Jim Fehlig]

On 2/17/22 04:56, Michal Privoznik wrote:
> When I implemented user aliases I've invented this
> virDomainDefFeatures flag so that individual drivers can signal
> support for user provided aliases. The reasoning was that a
> device alias might be part of guest ABI, or used in a different
> way then in QEMU. Well, neither applies to the libxl driver, so
> it's safe to allow user aliases there.

I suppose it is safe, but does it make sense since aliases are not used by the 
driver in any way, and not supported by libxl?

Regards,
Jim

> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/231
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>   src/libxl/libxl_domain.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index c91e531a9a..0816c5baa4 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -452,7 +452,8 @@ virDomainDefParserConfig libxlDomainDefParserConfig = {
>       .domainPostParseCallback = libxlDomainDefPostParse,
>       .domainValidateCallback = libxlDomainDefValidate,
>   
> -    .features = VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT |
> +    .features = VIR_DOMAIN_DEF_FEATURE_USER_ALIAS |
> +                VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT |
>                   VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING,
>   };
>