[PATCH 20/23] virsh: cmdDesc: Automatically free memory

Peter Krempa pkrempa at redhat.com
Wed Mar 2 13:55:19 UTC 2022


Decrease scope of variables and use automatic freeing.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tools/virsh-domain.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index dcf0f712f6..4d9722f400 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -8333,9 +8333,7 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)

     int state;
     int type;
-    char *desc = NULL;
-    char *desc_edited = NULL;
-    char *tmpstr;
+    g_autofree char *desc = NULL;
     const vshCmdOpt *opt = NULL;
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     bool ret = false;
@@ -8379,6 +8377,8 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)

         if (edit) {
             g_autoptr(vshTempFile) tmp = NULL;
+            g_autofree char *desc_edited = NULL;
+            char *tmpstr;

             /* Create and open the temporary file. */
             if (!(tmp = vshEditWriteToTempFile(ctl, desc)))
@@ -8438,8 +8438,6 @@ cmdDesc(vshControl *ctl, const vshCmd *cmd)

     ret = true;
  cleanup:
-    VIR_FREE(desc_edited);
-    VIR_FREE(desc);
     return ret;
 }

-- 
2.35.1




More information about the libvir-list mailing list