[PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize

Daniel P. Berrangé berrange at redhat.com
Fri Mar 4 18:56:12 UTC 2022


This small series was motivated by my thoughts on the proposals in

  https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg01135.html

It demonstrates the approach I mention there, and has the further
benefit of untangling and isolating the implementation of UID
changing, chrooting and daemonizing, from the parsing of the
corresponding command line options.

Changed in v2:

 - Fix mistake that left stderr open when daemonizing
 - Remove use of is_daemonized from chardev
 - Remove use of is_daemonized from logging
 - Eliminate is_daemonized function

Daniel P. Berrangé (8):
  softmmu: remove deprecated --enable-fips option
  os-posix: refactor code handling the -runas argument
  os-posix: refactor code handling the -chroot argument
  util: remove use of is_daemonized flag from logging code
  softmmu: refactor use of is_daemonized() method
  chardev: add API to block use of the stdio implementation
  softmmu: move parsing of -runas, -chroot and -daemonize code
  softmmu: remove is_daemonized() method

 chardev/char-stdio.c            |  12 +-
 docs/about/deprecated.rst       |  12 --
 docs/about/removed-features.rst |  11 ++
 include/chardev/char-stdio.h    |  29 ++++
 include/qemu/log.h              |   1 +
 include/qemu/osdep.h            |   3 -
 include/sysemu/os-posix.h       |   6 +-
 include/sysemu/os-win32.h       |   6 -
 os-posix.c                      | 227 ++++++++++----------------------
 os-win32.c                      |   9 --
 qemu-options.hx                 |  10 --
 softmmu/vl.c                    |  92 +++++++++++--
 stubs/is-daemonized.c           |   9 --
 stubs/meson.build               |   1 -
 ui/vnc.c                        |   7 -
 util/log.c                      |  12 +-
 util/osdep.c                    |  28 ----
 17 files changed, 213 insertions(+), 262 deletions(-)
 create mode 100644 include/chardev/char-stdio.h
 delete mode 100644 stubs/is-daemonized.c

-- 
2.34.1





More information about the libvir-list mailing list