[PATCH 4/4] docs: formatsnapshot: Remove empty 'seclabel' definition

Michal Prívozník mprivozn at redhat.com
Wed Mar 9 10:10:27 UTC 2022


On 3/9/22 11:04, Peter Krempa wrote:
> On Wed, Mar 09, 2022 at 10:48:55 +0100, Michal Prívozník wrote:
>> On 3/9/22 10:09, Peter Krempa wrote:
>>> The security label setting for the external images is part of the
>>> 'source' element and documented there. Remove the empty definition added
>>> accidentally in commit ac88a8cfad1
>>>
>>> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>>> ---
>>>  docs/formatsnapshot.rst | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/docs/formatsnapshot.rst b/docs/formatsnapshot.rst
>>> index e0f4c72235..0fee35d89c 100644
>>> --- a/docs/formatsnapshot.rst
>>> +++ b/docs/formatsnapshot.rst
>>> @@ -160,8 +160,6 @@ The top-level ``domainsnapshot`` element may contain the following elements:
>>>           sub-element can be used with same semantics as the identically named
>>>           subelement of the domain definition disk's driver.
>>>
>>> -   ``seclabel``
>>> -
>>>  ``creationTime``
>>>
>>>     A readonly representation of the time this snapshot was created. The time is
>>
>> Ah, alright so my comment to 2/4 is not true completely. Maybe squash
>> these two together? Or don't, I don't care that much.
> 
> The problem is that the paragraph I moved in 2/4 didn't belong at all
> under the seclabel heading. I can reorder them, but other than that it's
> completely separate.
> 

Nah, probably not worth the extra work. Merge these as they are.

Michal



More information about the libvir-list mailing list