[libvirt PATCH] ci: integration: Rename all Avocado standard stream log files to *.log

Andrea Bolognani abologna at redhat.com
Tue Mar 22 17:36:24 UTC 2022

On Tue, Mar 22, 2022 at 06:23:47PM +0100, Erik Skultety wrote:
> On Tue, Mar 22, 2022 at 05:17:28PM +0000, Andrea Bolognani wrote:
> > On Tue, Mar 22, 2022 at 01:11:22PM +0100, Erik Skultety wrote:
> > > Since GitLab sets a proper MIME for .txt and .log file extensions,
> > > rename all Avocado log files without an extension to *.log . This pairs
> > > nicely with the coredumpctl info file which we already name as
> > > 'coredumpctl.txt' because of this.
> >
> > Just a nit that you should feel free to ignore, especially seeing how
> > you've already pushed this patch, but isn't what you've written above
> > an argument for either using .txt here or using .log for the
> > coredumpctl case too?
> I mean, okay, technically you're right, but can coredumpctl.txt really be
> considered anything even remotely connected to logging that would justify the
> extension? (since you decided to paint the shed...)

I don't see how it's different from the stdout.log generated by
Avocado - in both cases you're writing the output produced by a
program to a file.

Anyway, it doesn't really matter, we can mix and match as long as
it's still possible to conveniently visualize the file in the browser
as opposed to having to jump through additional hoops :)

Andrea Bolognani / Red Hat / Virtualization

More information about the libvir-list mailing list