[PATCH] virConnectDomainEventRegisterAny: correct docs

Michal Prívozník mprivozn at redhat.com
Mon Mar 28 14:21:15 UTC 2022


On 3/25/22 17:03, John Levon wrote:
> The callback ID can be zero, not necessarily positive; correct the
> comment to reflect this.
> 
> Signed-off-by: John Levon <levon at movementarian.org>
> ---
>  src/libvirt-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index a197618673..53efb60406 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -9486,7 +9486,7 @@ virDomainMigrateStartPostCopy(virDomainPtr domain,
>   * The reference can be released once the object is no longer required
>   * by calling virDomainFree().
>   *
> - * The return value from this method is a positive integer identifier
> + * The return value from this method is a non-negative integer identifier
>   * for the callback. To unregister a callback, this callback ID should
>   * be passed to the virConnectDomainEventDeregisterAny() method.
>   *

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

and pushed. Congratulations on your first libvirt contribution.

Michal



More information about the libvir-list mailing list