[libvirt PATCH] tests: Add test for missing network attribute in graphics' listen element

Martin Kletzander mkletzan at redhat.com
Wed May 4 12:57:17 UTC 2022


This tests a change done in commit 871a071abb9c.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 .../graphics-listen-network-invalid.xml       | 29 +++++++++++++++++++
 tests/genericxml2xmltest.c                    |  1 +
 2 files changed, 30 insertions(+)
 create mode 100644 tests/genericxml2xmlindata/graphics-listen-network-invalid.xml

diff --git a/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml b/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml
new file mode 100644
index 000000000000..87b5a32abe87
--- /dev/null
+++ b/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml
@@ -0,0 +1,29 @@
+<domain type='qemu'>
+  <name>QEMUGuest1</name>
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+  <memory unit='KiB'>219100</memory>
+  <currentMemory unit='KiB'>219100</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='i686' machine='pc'>hvm</type>
+    <boot dev='hd'/>
+  </os>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <controller type='usb' index='0'/>
+    <controller type='ide' index='0'/>
+    <controller type='pci' index='0' model='pci-root'/>
+    <input type='mouse' bus='ps2'/>
+    <input type='keyboard' bus='ps2'/>
+    <graphics type='vnc'>
+      <listen type='network'/>
+    </graphics>
+    <video>
+      <model type='cirrus' vram='16384' heads='1' primary='yes'/>
+    </video>
+    <memballoon model='none'/>
+  </devices>
+</domain>
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
index 34ccaff61503..87014e3e531f 100644
--- a/tests/genericxml2xmltest.c
+++ b/tests/genericxml2xmltest.c
@@ -174,6 +174,7 @@ mymain(void)
     DO_TEST_DIFFERENT("graphics-vnc-socket-attr-listen-socket");
     DO_TEST_FAIL_ACTIVE("graphics-vnc-socket-attr-listen-socket-mismatch");
     DO_TEST("graphics-vnc-autoport-no");
+    DO_TEST_FAIL_INACTIVE("graphics-listen-network-invalid");
 
     DO_TEST_FAIL_ACTIVE("name-slash-fail");
 
-- 
2.35.1



More information about the libvir-list mailing list