[PATCH] Support cpu0-id of Qemu QMP query-sev-capabilities

Michal Prívozník mprivozn at redhat.com
Thu May 5 10:30:45 UTC 2022


On 4/27/22 21:57, Niteesh Dubey wrote:
> It allows libvirt to provide the value of cpu0-id retuned by the Qemu QMP
>  command query-sev-capabilities as implemented by the Qemu Patch [1] which
>  is merged to Qemu master branch and should be available with Qemu 7.1.
>  This is used to get the signed Chip Endorsement Key (CEK) of the CPU of AMD
>  system from AMD's Key Distribution Service (KDS).
> 
> Similar to  cbitpos, reducedPhysBits, maxGuests & maxESGuests;
>  the value of cpu0-id is also provided using 'virsh domcapability'.
> 
> [1] https://lore.kernel.org/all/20220228093014.882288-1-dovmurik@linux.ibm.com/
> 
> Signed-off-by: Niteesh Dubey <niteesh at linux.ibm.com>
> ---
>  include/libvirt/libvirt-host.h | 11 +++++++++++
>  src/conf/domain_capabilities.c |  4 ++++
>  src/conf/domain_capabilities.h |  1 +
>  src/qemu/qemu_capabilities.c   | 12 ++++++++++++
>  src/qemu/qemu_driver.c         |  5 +++++
>  src/qemu/qemu_monitor_json.c   |  6 ++++++
>  6 files changed, 39 insertions(+)
> 
> diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h
> index b5cf8a4a4a..d35abbd9aa 100644
> --- a/include/libvirt/libvirt-host.h
> +++ b/include/libvirt/libvirt-host.h
> @@ -537,6 +537,17 @@ typedef virNodeMemoryStats *virNodeMemoryStatsPtr;
>   */
>  # define VIR_NODE_SEV_CERT_CHAIN "cert-chain"
>  
> +/**
> + * VIR_NODE_SEV_CPU0_ID:
> + *
> + * Macro represents the unique ID of CPU0 (socket 0) needed to retrieve
> + * the signed CEK of the CPU from AMD's Key Distribution Service (KDS),
> + * as VIR_TYPED_PARAMS_STRING.
> + *
> + * Since: v8.3.1

The next release is 8.4.0. The micro version number is reserved for
maintanance releases (e.g. when a critical bug fix is backported). But
we don't really do those.

Anyway, fixed this small nit and pushed. Congratulations on your first
libvirt contribution!

Michal



More information about the libvir-list mailing list