[libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

Daniel P. Berrangé berrange at redhat.com
Fri May 6 11:53:25 UTC 2022


On Fri, May 06, 2022 at 01:48:33PM +0200, Claudio Fontana wrote:
> On 5/6/22 1:02 PM, Daniel P. Berrangé wrote:
> > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote:
> >> where it can be reused by other helpers.
> >> No changes other than the move.
> >>
> >> Note that this makes iohelper now dependent on -lutil, because unused
> >> (for iohelper) parts of virfile.c contain calls to openpty(3).
> > 
> > Needs -lacl too on F35 at least.
> 
> Can you help me figure out where this need comes from, to ensure we are not missing anything else?
> On my SUSE systems it's not needed, maybe some other OS needs more -l parameters?

Just let the gitlab CI run, and if it passes all jobs, we're fine.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the libvir-list mailing list