[libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

Claudio Fontana cfontana at suse.de
Fri May 6 12:01:39 UTC 2022


On 5/6/22 1:54 PM, Daniel P. Berrangé wrote:
> On Fri, May 06, 2022 at 01:51:53PM +0200, Claudio Fontana wrote:
>> On 5/6/22 1:02 PM, Daniel P. Berrangé wrote:
>>> On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote:
>>>> where it can be reused by other helpers.
>>>> No changes other than the move.
>>>>
>>>> Note that this makes iohelper now dependent on -lutil, because unused
>>>> (for iohelper) parts of virfile.c contain calls to openpty(3).
>>>
>>> Needs -lacl too on F35 at least.
>>
>> do we end up needing the whole of the virt_util_lib dependencies for this?
>>
>>  dependencies: [
>>     acl_dep,
>>     audit_dep,
>>     capng_dep,
>>     devmapper_dep,
>>     gnutls_dep,
>>     intl_dep,
>>     libm_dep,
>>     libnl_dep,
>>     libutil_dep,
>>     numactl_dep,
>>     secdriver_dep,
>>     src_dep,
>>     thread_dep,
>>     win32_dep,
>>     yajl_dep,
>> ]
>>
>> iohelper did not need -lutil or anything else before, just a file.
>> going back to just a separate helper_runio.c/h would make sense to me, but let me know.
> 
> The linker will discard all the .o files that don't have any functions
> referenced, so we'll not need most of what virt_util_lib depends on,
> just the virfile.o deps.

Aye aye,

Thanks,

Claudio



More information about the libvir-list mailing list