[PATCH 2/3] ui: Switch "-display sdl" to use the QAPI parser
Daniel P. Berrangé
berrange at redhat.com
Thu May 12 08:20:59 UTC 2022
On Wed, May 11, 2022 at 07:51:46PM +0200, Thomas Huth wrote:
> The "-display sdl" option still uses a hand-crafted parser for its
> parameters since some of them used underscores which is forbidden
> in QAPI. Now that the problematic parameters have been removed, we can
> switch to use the QAPI parser instead.
>
> This introduces the new "DisplaySDL" QAPI struct that is used to hold
> the parameters that are unique to the SDL display. The only specific
> parameter is currently "grab-mod" which is modeled as a string, so that
> it could be extended for other arbitrary modifiers later more easily.
>
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
> qapi/ui.json | 17 +++++++++-
> include/sysemu/sysemu.h | 2 --
> softmmu/globals.c | 2 --
> softmmu/vl.c | 70 +----------------------------------------
> ui/sdl2.c | 13 ++++++++
> 5 files changed, 30 insertions(+), 74 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list