[libvirt PATCH 3/4] qemu: Make migration events mandatory

Jiri Denemark jdenemar at redhat.com
Thu May 12 08:55:46 UTC 2022


All QEMU versions we care about support migration events and we should
be able to enable the associated capability when connecting to the
monitor. Failure to do so is thus considered fatal now.

Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
 src/qemu/qemu_migration_params.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index ec288b9fa1..26754f03f8 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -1433,10 +1433,8 @@ qemuMigrationCapsCheck(virQEMUDriver *driver,
 
     qemuDomainObjExitMonitor(vm);
 
-    if (rc < 0) {
-        virResetLastError();
-        VIR_DEBUG("Cannot enable migration events");
-    }
+    if (rc < 0)
+        return -1;
 
     /* Migration events capability must always be enabled, clearing it from
      * migration capabilities bitmap makes sure it won't be touched anywhere
-- 
2.35.1



More information about the libvir-list mailing list