[PATCH] lib: Rename VIR_SAVE_PARAM_* to VIR_DOMAIN_SAVE_PARAM_*
Daniel P. Berrangé
berrange at redhat.com
Thu May 12 08:57:57 UTC 2022
On Thu, May 12, 2022 at 10:31:10AM +0200, Michal Privoznik wrote:
> A few commits ago new APIs were introduced (virDomainSaveParams()
> and virDomainRestoreParams()) and with them new typed parameters:
> VIR_SAVE_PARAM_FILE and VIR_SAVE_PARAM_DXML. But their name does
> not suggest they apply to either of the APIs nor that they are
> intended for domain related APIs. Switch to
> VIR_DOMAIN_SAVE_PARAM prefix to make it obvious.
>
> It's true we already have VIR_DOMAIN_SAVE_* symbols which are
> part of virDomainSaveRestoreFlags enum, therefore stick also with
> '_PARAM_ ' part of the name to differentiate the two.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> include/libvirt/libvirt-domain.h | 8 ++++----
> src/qemu/qemu_driver.c | 22 ++++++++++++++--------
> 2 files changed, 18 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list