[libvirt PATCH 78/80] qemu: Implement VIR_DOMAIN_ABORT_JOB_POSTCOPY flag

Peter Krempa pkrempa at redhat.com
Thu May 12 12:53:24 UTC 2022


On Thu, May 12, 2022 at 14:52:11 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:39 +0200, Jiri Denemark wrote:
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/qemu/qemu_driver.c       | 43 +++++++++++++++++++++++++++++-------
> >  src/qemu/qemu_monitor.c      |  9 ++++++++
> >  src/qemu/qemu_monitor.h      |  3 +++
> >  src/qemu/qemu_monitor_json.c | 22 ++++++++++++++++++
> >  src/qemu/qemu_monitor_json.h |  3 +++
> >  5 files changed, 72 insertions(+), 8 deletions(-)
> 
> [...]

[...]

> Also add the trivial qemumonitorjsontest case so that this undergoes QMP
> schema validation, even when it's a trivial command.
> 
> With both of the above addressed:
> 
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>

One other thing to consider would be to reject the API if the postcopy
flag is used but the migration is not post-copy or it's a backup job.


More information about the libvir-list mailing list