[libvirt PATCH 03/80] qemu: Return state from qemuMonitorGetMigrationCapabilities

[Jiri Denemark]

On Wed, May 11, 2022 at 10:30:24 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:20:24 +0200, Jiri Denemark wrote:
> > The function can now optionally return a bitmap describing the current
> > state of each migration capability.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/qemu/qemu_capabilities.c     |  2 +-
> >  src/qemu/qemu_migration_params.c |  2 +-
> >  src/qemu/qemu_monitor.c          |  5 +++--
> >  src/qemu/qemu_monitor.h          |  3 ++-
> >  src/qemu/qemu_monitor_json.c     | 18 +++++++++++++++++-
> >  src/qemu/qemu_monitor_json.h     |  3 ++-
> >  tests/qemumonitorjsontest.c      | 12 +++++++++++-
> >  7 files changed, 37 insertions(+), 8 deletions(-)
> 
> [...]
> 
> > diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> > index 9e611e93e8..532aad348e 100644
> > --- a/src/qemu/qemu_monitor_json.c
> > +++ b/src/qemu/qemu_monitor_json.c
> > @@ -6210,12 +6210,14 @@ qemuMonitorJSONGetTargetArch(qemuMonitor *mon)
> 
> I'm not exactly a fan of such loose correlation of data. Asking you to
> return a list of stucts would probably cause too much conflicts though,
> so as an alternative please document the relation between the
> 'capabilities' array and the positions in the 'state' bitmap in the
> comment for this function (that you'll need to add).

This patch was replaced with the "qemu: Drop QEMU_CAPS_MIGRATION_EVENT"
series.

Jirka