[libvirt PATCH 67/80] qemu: Start a migration phase in qemuMigrationAnyConnectionClosed

Peter Krempa pkrempa at redhat.com
Thu May 12 15:12:07 UTC 2022


On Tue, May 10, 2022 at 17:21:28 +0200, Jiri Denemark wrote:
> Non-postcopy case talks to QEMU monitor and thus needs to create a
> nested job. Since qemuMigrationAnyConnectionClosed is called in case
> there's no thread processing a migration API, we need to make the
> current thread a temporary owner of the migration job to avoid "This
> thread doesn't seem to be the async job owner: 0". This is done by
> starting a migration phase.
> 
> While no monitor interaction happens in postcopy case and just setting
> the phase (to indicate a broken postcopy migration) would be enough,
> being consistent and setting the owner does not hurt anything.

Especially since you clear it right after that :)

> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list