[PATCH 6/9] qemuFDPassValidate: Don't validate file descriptors

Peter Krempa pkrempa at redhat.com
Tue May 17 09:07:23 UTC 2022


The callers adding the FDs are validating them regardless so this check
was redundant.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_fd.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c
index 442f92df2f..fc9fecbb0e 100644
--- a/src/qemu/qemu_fd.c
+++ b/src/qemu/qemu_fd.c
@@ -68,8 +68,6 @@ qemuFDPassFree(qemuFDPass *fdpass)
 static int
 qemuFDPassValidate(qemuFDPass *fdpass)
 {
-    size_t i;
-
     if (!fdpass->useFDSet &&
         fdpass->nfds > 1) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -77,14 +75,6 @@ qemuFDPassValidate(qemuFDPass *fdpass)
         return -1;
     }

-    for (i = 0; i < fdpass->nfds; i++) {
-        if (fdpass->fds[i].fd < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("invalid file descriptor"));
-            return -1;
-        }
-    }
-
     return 0;
 }

-- 
2.35.3



More information about the libvir-list mailing list