[PATCH v2 2/2] cpu_ppc64: add support for host-model on POWER10

[Daniel Henrique Barboza]

On 5/12/22 04:52, Andrea Bolognani wrote:
> On Thu, May 05, 2022 at 05:26:14PM -0300, Daniel Henrique Barboza wrote:
>> +++ b/tests/qemuxml2argvtest.c
>> @@ -2209,6 +2209,17 @@ mymain(void)
>>               QEMU_CAPS_DEVICE_SPAPR_VTY);
>>       qemuTestSetHostCPU(&driver, driver.hostarch, NULL);
>>
>> +    DO_TEST_FAILURE("pseries-cpu-compat-power10",
>> +                    QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE,
>> +                    QEMU_CAPS_KVM);
>> +
>> +    qemuTestSetHostCPU(&driver, driver.hostarch, cpuPower10);
>> +    DO_TEST("pseries-cpu-compat-power10",
>> +            QEMU_CAPS_KVM,
>> +            QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE,
>> +            QEMU_CAPS_DEVICE_SPAPR_VTY);
> 
> Don't forget to add the new test case to qemuxml2xmltest too.
> 
> It would be great if, as a follow-up, you could look into converting
> these test cases to the DO_TEST_CAPS_ARCH_LATEST_* macros, which
> would allow us to drop the hardcoded list of capabilities.

Right. Guess I'll use ARCH_LATEST in the tests I'm adding in this patch as well.



Daniel

> 
>> +++ b/tests/testutilsqemu.c
>> @@ -22,6 +22,7 @@ virCPUDef *cpuDefault;
>>   virCPUDef *cpuHaswell;
>>   virCPUDef *cpuPower8;
>>   virCPUDef *cpuPower9;
>> +virCPUDef *cpuPower10;
> 
> This part, as well as others, no longer applies. Easy enough to fix.
> 
> Can you please update the NEWS file to mention the new feature?
>