[libvirt PATCH] util: Do not report useless error in virPortAllocatorRelease

Jiri Denemark jdenemar at redhat.com
Wed May 18 08:08:23 UTC 2022


If the port allocator bitmap does not have enough bits to keep the state
of the port we're going to release, the port is not reserved and thus is
trivially released without doing anything. No need to report an error in
such case.

Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
 src/util/virportallocator.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
index 44edd8f99a..97ab362749 100644
--- a/src/util/virportallocator.c
+++ b/src/util/virportallocator.c
@@ -254,12 +254,7 @@ virPortAllocatorRelease(unsigned short port)
         return 0;
 
     VIR_WITH_OBJECT_LOCK_GUARD(pa) {
-        if (virBitmapClearBit(pa->bitmap, port) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("Failed to release port %d"),
-                           port);
-            return -1;
-        }
+        ignore_value(virBitmapClearBit(pa->bitmap, port));
     }
 
     return 0;
-- 
2.35.1



More information about the libvir-list mailing list