[libvirt PATCH v2 2/7] po: Stop using 'glib' preset for i18n.gettext()

Andrea Bolognani abologna at redhat.com
Wed May 18 09:52:40 UTC 2022


Due to a bug in meson versions earlier than 0.60, the
--add-comments that's part of the 'glib' preset and the
--add-comments=TRANSLATORS: that we add ourselves might be
passed to xgettext in the wrong order, resulting in a bunch of
comments that we don't care about being added to the potfile.

Most of the options included in the 'glib' preset are not
applicable to libvirt anyway, so just stop using the preset and
pass a few extra options explicitly instead.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 po/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/po/meson.build b/po/meson.build
index f4d95f97fe..d13466bc06 100644
--- a/po/meson.build
+++ b/po/meson.build
@@ -14,6 +14,9 @@ potfiles = configure_file(
 i18n.gettext(
   meson.project_name(),
   args: [
+    '--from-code=UTF-8',
+    '--keyword=_',
+    '--keyword=N_',
     '--add-comments=TRANSLATORS:',
     '--directory=@0@'.format(meson.source_root()),
     '--directory=@0@'.format(meson.build_root()),
@@ -22,7 +25,6 @@ i18n.gettext(
     '--package-version=@0@'.format(meson.project_version()),
     '--sort-output',
   ],
-  preset: 'glib',
 )
 
 potfiles_dep = [
-- 
2.35.3



More information about the libvir-list mailing list