[PATCH v2 1/3] ui: Remove deprecated parameters of the "-display sdl" option

Markus Armbruster armbru at redhat.com
Wed May 18 15:04:05 UTC 2022


Thomas Huth <thuth at redhat.com> writes:

> These parameters are in the way for further refactoring (since they
> use an underscore in the name which is forbidden in QAPI), so let's
> remove these now that their deprecation period is over.

Forbidden, but there's an exception mechanism, so this reason isn't
compelling.  I believe the actual reason is they are "too ugly and
inflexible to drag them along into the QAPI world" (your words).

Suggest:

  Dropping these deprecated parameters now simplifies further
  refactoring.

> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
> Signed-off-by: Thomas Huth <thuth at redhat.com>

Patch looks good to me, so
Reviewed-by: Markus Armbruster <armbru at redhat.com>


More information about the libvir-list mailing list